-
Notifications
You must be signed in to change notification settings - Fork 1k
Add source to import flow pixels #6310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
CDRussell
merged 1 commit into
develop
from
feature/craig/autofill/promo_import_add_source_to_import_flow_pixels
Jul 2, 2025
Merged
Add source to import flow pixels #6310
CDRussell
merged 1 commit into
develop
from
feature/craig/autofill/promo_import_add_source_to_import_flow_pixels
Jul 2, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2025
This was referenced Jun 27, 2025
85126e5
to
510844a
Compare
dd71734
to
df62daf
Compare
510844a
to
b7e571e
Compare
cmonfortep
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Merge activity
|
b7e571e
to
5bdaffe
Compare
This was referenced Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/task/1210421589932466
Description
Updates the pixels around password import prompts/buttons/dialogs, namely to include a
source
parameter indicating where the import was launched from.Possible values:
password_management_promo
password_management_empty_state
password_management_overflow
autofill_settings_button
unknown
(should never happen in reality)Steps to test this PR
Suggested logcat filter:
message~:"Pixel sent.*source="
Password management view
autofill_import_google_passwords_import_button_shown with params: {source=password_management_empty_state}
autofill_import_google_passwords_preimport_prompt_displayed with params: {source=password_management_empty_state}
autofill_import_google_passwords_import_button_tapped with params: {source=password_management_empty_state}
autofill_import_google_passwords_result_user_cancelled with params: {stage=pre-import-dialog, source=password_management_empty_state}
autofill_import_google_passwords_import_button_shown with params: {source=password_management_promo}
autofill_import_google_passwords_import_button_tapped with params: {source=password_management_promo}
Import Passwords From Google
.autofill_import_google_passwords_overflow_menu_tapped with params: {source=password_management_overflow}
autofill_import_google_passwords_preimport_prompt_displayed with params: {source=password_management_overflow}
Password settings screen
Passwords & Autofill
autofill_import_google_passwords_import_button_shown with params: {source=autofill_settings_button}