Skip to content

Add source to import flow pixels #6310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Jun 27, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/task/1210421589932466

Description

Updates the pixels around password import prompts/buttons/dialogs, namely to include a source parameter indicating where the import was launched from.

Possible values:

  • password_management_promo
  • password_management_empty_state
  • password_management_overflow
  • autofill_settings_button
  • unknown (should never happen in reality)

Steps to test this PR

Suggested logcat filter: message~:"Pixel sent.*source="

Password management view

  • Fresh install, and visit Passwords from the browser overflow menu
  • Verify: autofill_import_google_passwords_import_button_shown with params: {source=password_management_empty_state}
  • Verify: autofill_import_google_passwords_preimport_prompt_displayed with params: {source=password_management_empty_state}
  • Verify: autofill_import_google_passwords_import_button_tapped with params: {source=password_management_empty_state}
  • Dismiss the dialog. Verify: autofill_import_google_passwords_result_user_cancelled with params: {stage=pre-import-dialog, source=password_management_empty_state}
  • Manually add a password and return to the list
  • Verify you see the password import promo, and autofill_import_google_passwords_import_button_shown with params: {source=password_management_promo}
  • Tap the promo CTA; verify: autofill_import_google_passwords_import_button_tapped with params: {source=password_management_promo}
  • Complete or cancel the import flow to return to the password list. Tap on overflow and choose Import Passwords From Google.
  • Verify: autofill_import_google_passwords_overflow_menu_tapped with params: {source=password_management_overflow}
  • Verify: autofill_import_google_passwords_preimport_prompt_displayed with params: {source=password_management_overflow}

Password settings screen

  • Leave management screen, and visit app settings, then Passwords & Autofill
  • Verify: autofill_import_google_passwords_import_button_shown with params: {source=autofill_settings_button}

@CDRussell CDRussell force-pushed the feature/craig/autofill/promo_import_add_source_to_import_flow_pixels branch 2 times, most recently from 85126e5 to 510844a Compare July 1, 2025 10:50
@CDRussell CDRussell marked this pull request as ready for review July 1, 2025 10:56
@CDRussell CDRussell force-pushed the feature/craig/autofill/promo_import_cta_design_changes branch from dd71734 to df62daf Compare July 1, 2025 11:05
@CDRussell CDRussell force-pushed the feature/craig/autofill/promo_import_add_source_to_import_flow_pixels branch from 510844a to b7e571e Compare July 1, 2025 11:05
Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member Author

CDRussell commented Jul 2, 2025

Merge activity

  • Jul 2, 9:09 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 2, 10:31 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 2, 10:44 AM UTC: @CDRussell merged this pull request with Graphite.

@CDRussell CDRussell changed the base branch from feature/craig/autofill/promo_import_cta_design_changes to graphite-base/6310 July 2, 2025 10:14
@CDRussell CDRussell changed the base branch from graphite-base/6310 to develop July 2, 2025 10:29
@CDRussell CDRussell force-pushed the feature/craig/autofill/promo_import_add_source_to_import_flow_pixels branch from b7e571e to 5bdaffe Compare July 2, 2025 10:30
@CDRussell CDRussell merged commit 7d5b6a3 into develop Jul 2, 2025
7 checks passed
@CDRussell CDRussell deleted the feature/craig/autofill/promo_import_add_source_to_import_flow_pixels branch July 2, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants